HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45892 )
Change subject: sb/amd/*/*/smbus.h: Make 'smbus.h' uniform ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45892/1/src/southbridge/amd/cimx/sb... File src/southbridge/amd/cimx/sb800/smbus.h:
https://review.coreboot.org/c/coreboot/+/45892/1/src/southbridge/amd/cimx/sb... PS1, Line 25: #define AX_INDXP 2 AX_INDXP is 1 or 2 ?
"In file included from src/southbridge/amd/cimx/sb800/late.c:23: src/southbridge/amd/cimx/sb800/smbus.h:25: error: "AX_INDXP" redefined [-Werror] #define AX_INDXP 2
In file included from src/southbridge/amd/cimx/sb800/SBPLATFORM.h:41, from src/southbridge/amd/cimx/sb800/late.c:19: src/vendorcode/amd/cimx/sb800/SB800.h:709: note: this is the location of the previous definition #define AX_INDXP 1"