Hello HIMANSHU SAHDEV,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/35292
to review the following change.
Change subject: arch/x86/bootblock_crt0.S: Leverage eax in protected mode entry ......................................................................
arch/x86/bootblock_crt0.S: Leverage eax in protected mode entry
Leverage already used eax register in bootblock_protected_mode_entry. Avoid another register ebx just for preserving eax value as it is not used at all after the assignment. Allow EBX to be preserved for other usage.
Change-Id: Ia668b78f2f97cf026692f1fe63ff8a382a162474 Signed-off-by: Himanshu Sahdev himanshusah@hcl.com --- M src/arch/x86/bootblock_crt0.S 1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/35292/1
diff --git a/src/arch/x86/bootblock_crt0.S b/src/arch/x86/bootblock_crt0.S index ea55096..272a4eb 100644 --- a/src/arch/x86/bootblock_crt0.S +++ b/src/arch/x86/bootblock_crt0.S @@ -48,11 +48,10 @@ /* MMX registers required here */
/* BIST result in eax */ - movl %eax, %ebx + movd %eax, %mm0
/* Get an early timestamp */ rdtsc - movd %ebx, %mm0 movd %eax, %mm1 movd %edx, %mm2 #endif