Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40515 )
Change subject: ec/google/chromeec: Add driver for i2c_tunnel device under Chrome EC ......................................................................
Patch Set 11:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40515/11/src/ec/google/chromeec/Kco... File src/ec/google/chromeec/Kconfig:
https://review.coreboot.org/c/coreboot/+/40515/11/src/ec/google/chromeec/Kco... PS11, Line 200: if EC_GOOGLE_CHROMEEC
This makes it look as if the files won't get sourced unless EC_GOOGLE_CHROMEEC is set, which isn't the case.
Maybe I am misunderstanding the syntax here. But, my intent is to ensure that the files don't get sourced unless EC_GOOGLE_CHROMEEC is true. Are you saying that is not what this is doing?
In the sourced file, there's nothing to show that it won't get run unless EC_GOOGLE_CHROMEEC is set.
I put it here because it relieves all the sub-Kconfigs from adding this check. I see that it is also being used in other places like soc/intel/common, soc/amd/common.