Brandon Breitenstein has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39460 )
Change subject: mainboard: Set Tiger Lake platforms to have retimer config Aux orientation ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39460/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39460/1//COMMIT_MSG@9 PS1, Line 9: Type-C ports on all the Tiger Lake platforms have retimers
I don't think this is true. We can have type c ports w/o a retimer.
I will reword this...I clarified the difference for Volteer below
https://review.coreboot.org/c/coreboot/+/39460/1/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/39460/1/src/mainboard/google/voltee... PS1, Line 115: register "TcssAuxOri" = "0"
What are the value options for this field? If there's not a retimer that fixes the orientation what' […]
this is a bitwise field relating to each port if the flip is needed the corresponding bit x2 needs to be set please see the FspsUpd.h file for more info on this
/** Offset 0x04CE - TCSS Aux Orientation Override Enable Bits 0, 2, ... 10 control override enables, bits 1, 3, ... 11 control overrides **/