Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46509 )
Change subject: mrc_cache: Add config MRC_SAVE_HASH_IN_TPM
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46509/2/src/drivers/mrc_cache/Kconf...
File src/drivers/mrc_cache/Kconfig:
https://review.coreboot.org/c/coreboot/+/46509/2/src/drivers/mrc_cache/Kconf...
PS2, Line 54: VBOOT
This should be VBOOT_STARTS_IN_BOOTBLOCK because the mrc_cache.c code is enforcing that.
Oh I guess you removed that in the next patch? I agree that I'm not sure why that restriction was there... but if you want to remove that, you should do it in this patch already to keep things in sync.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46509
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic5ffcdba27cb1f09c39c3835029c8d9cc3453af1
Gerrit-Change-Number: 46509
Gerrit-PatchSet: 3
Gerrit-Owner: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Fri, 16 Oct 2020 22:55:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment