Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32867 )
Change subject: device_tree: Match debug output format to dtc -O dts output ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/#/c/32867/5/src/lib/device_tree.c File src/lib/device_tree.c:
https://review.coreboot.org/#/c/32867/5/src/lib/device_tree.c@481 PS5, Line 481:
should we use space to replace tab here?
I mean, I don't know... do you think I should? I think tabs can help make comments stand out more and be more readable when there's space for it. There's no strict rule one way or the other about it in the style guide as far as I'm aware. (And all these formatting details will be lost like tears in the rain when the big clang-format bomb drops anyway...)