Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39454 )
Change subject: soc/intel/cannonlake: Steal no memory for disabled IGD
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39454/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/39454/1//COMMIT_MSG@11
PS1, Line 11:
It does what it says. It sets IgdDvmt50PreAlloc to zero if InternalGfx is disabled. […]
Sorry, it was only clear after reading the diff. Your explanation hear is more precise what is actually done. Maybe use that instead.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39454
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6f9e0f9855224614471d8ed23bf2a9786386ddca
Gerrit-Change-Number: 39454
Gerrit-PatchSet: 2
Gerrit-Owner: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Nate DeSimone
nateman1352@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 13 Mar 2020 10:11:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Christian Walter
christian.walter@9elements.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment