Attention is currently required from: Bao Zheng, Jason Glenesk, ritul guru, Zheng Bao, Fred Reitberger.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72507 )
Change subject: amdfwtool: Add entry RIB whose subprog equals 1
......................................................................
Patch Set 3:
(1 comment)
File util/amdfwtool/data_parse.c:
https://review.coreboot.org/c/coreboot/+/72507/comment/8ca8e86d_48557f59
PS2, Line 414: } else if (strcmp(fw_name, "PSP_RIB_FILE") == 0) {
Does this SUB1 often happen? […]
from document #55758 Rev. 2.02, Table 21 Sub-Programming Encoding i'd say that family 19h model 70h uses PSP_RIB_FILE_SUB0 and family 19h model 78h PSP_RIB_FILE_SUB1. we'll need to support both, so for consistency i'd use PSP_RIB_FILE_SUB0 instead of PSP_RIB_FILE to be consistent with PSP_RIB_FILE_SUB1
--
To view, visit
https://review.coreboot.org/c/coreboot/+/72507
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib013f264fc9940ad95e559fe19bba72c06a19625
Gerrit-Change-Number: 72507
Gerrit-PatchSet: 3
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: ritul guru
ritul.bits@gmail.com
Gerrit-Attention: Bao Zheng
fishbaozi@gmail.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: ritul guru
ritul.bits@gmail.com
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Comment-Date: Thu, 02 Feb 2023 13:43:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Bao Zheng
fishbaozi@gmail.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment