Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/44786 )
Change subject: gma registers: Allow to specify an offset for display registers ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/libgfxinit/+/44786/3/common/hw-gfx-gma-registe... File common/hw-gfx-gma-registers.adb:
https://review.coreboot.org/c/libgfxinit/+/44786/3/common/hw-gfx-gma-registe... PS3, Line 214: return Reg'Enum_Rep + Config.Display_Base_Offset / Register_Width;
I guess I should constrain the register range to remap here
It all depends on whether registers will be used that exist on other platforms and don't have that offset. I seem to remember that there were, but am not 100% sure. (Registers that you add for Bay Trail can all be adjustet to the offset.)