Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36358 )
Change subject: arch/x86/cbmem.c: Clean up unused paths ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36358/1/src/arch/x86/cbmem.c File src/arch/x86/cbmem.c:
https://review.coreboot.org/c/coreboot/+/36358/1/src/arch/x86/cbmem.c@22 PS1, Line 22: return (void *)restore_top_of_low_cacheable();
Assume this to be slow. It would be nice if the callee (cbmem_top()) would cache the value in romstage, even though we did not previously do it.
MAYBE_STATIC_BSS should cover the NO_CAR_GLOBAL_MIGRATION use case?