[coreboot-gerrit] Change in coreboot[master]: soc/intel/icelake: Remove redundant dependency check in cpu.c

[Aaron Durbin (Code Review)]

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36431 )

Change subject: soc/intel/icelake: Remove redundant dependency check in cpu.c
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/36431/2/src/soc/intel/icelake/bootb... 
File src/soc/intel/icelake/bootblock/cpu.c:

https://review.coreboot.org/c/coreboot/+/36431/2/src/soc/intel/icelake/bootb... 
PS2, Line 23: 	if (CONFIG(BOOT_DEVICE_MEMORY_MAPPED))
> Agree but as boot from block device is not POR on core platform hence can't we assume that core plat […]

If you are going to make that assumption then why have the BOOT_DEVICE_MEMORY_MAPPED check as well? If you are assuming it's always memory mapped and spi flash boot media, then it should be an unconditional call, right?