Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45337 )
Change subject: soc/intel/{cnl,ehl,icl,jsl,skl,tgl}: Make use of common reset code block
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45337/1/src/soc/intel/skylake/reset...
File src/soc/intel/skylake/reset.c:
https://review.coreboot.org/c/coreboot/+/45337/1/src/soc/intel/skylake/reset...
PS1, Line 25: void do_global_reset(void)
I agree. If SKL can use common CSE code, then perfect.
Done now, marking resolve 😊
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45337
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I71531f4cf7a40efa9ec55c48c2cb4fb6ea90531f
Gerrit-Change-Number: 45337
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 14 Sep 2020 14:20:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Gerrit-MessageType: comment