2 Jul
2019
2 Jul
'19
2:15 p.m.
Philipp Hug has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33934 )
Change subject: lib: Rewrite qemu-armv7 ramdetect ......................................................................
Patch Set 3:
(1 comment)
Thanks
https://review.coreboot.org/#/c/33934/3/src/mainboard/emulation/qemu-armv7/K... File src/mainboard/emulation/qemu-armv7/Kconfig:
https://review.coreboot.org/#/c/33934/3/src/mainboard/emulation/qemu-armv7/K... PS3, Line 55: config DRAM_SIZE_MB Why do you introduce a configuration for RAM size? Shouldn't this be detected automatically?
Maybe also add a TODO to get the RAM size from the fdt?
--
To view, visit https://review.coreboot.org/c/coreboot/+/33934
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I37386c6a95bfc3b7b25aeae32c6e14cff9913513
Gerrit-Change-Number: 33934
Gerrit-PatchSet: 3
Gerrit-Owner: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Asami Doi d0iasm.pub@gmail.com
Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com
Gerrit-Reviewer: Philipp Hug philipp@hug.cx
Gerrit-Reviewer: Xiang Wang wxjstz@126.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: ron minnich rminnich@gmail.com
Gerrit-CC: Patrick Rudolph siro@das-labor.org
Gerrit-Comment-Date: Tue, 02 Jul 2019 12:15:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment