[coreboot-gerrit] Change in coreboot[master]: WIP: Add configurable ramstage support for minimal PCI scanning

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36221 )

Change subject: WIP: Add configurable ramstage support for minimal PCI scanning
......................................................................

Patch Set 13:
> Unless we want to review every driver with a `.init` function if it can work without resources or runs into undefined behaviour, we should only call `.init` if `.read_resources` wasn't blocked. I guess we'll have to add some tag to `struct device`. This still means we'd have to review platform code that already avoids our devicetree model and accesses devices directly, e.g. with pci_dev_on_root(). Hmmm, same for `.final`.

I believe .init that only needs to access PCI configuration space should be allowed, even if resource BARs were left unassigned?

Any .init with a need to access registers behind BARs should already be using find_resource(), although it seems like we have cases where this is not followed by res == NULL check, though.

I started to wonder about that (coverity should have complained), and noticed there is die() in find_resource() already. Maybe address that instead of blocking .init calls?