Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40484 )
Change subject: nb/amd/agesa: read 256 bytes to SPD buffer instead of 128 ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40484/1/src/northbridge/amd/agesa/f... File src/northbridge/amd/agesa/family14/dimmSpd.c:
https://review.coreboot.org/c/coreboot/+/40484/1/src/northbridge/amd/agesa/f... PS1, Line 44: int err = smbus_readSpd(spdAddress, (void *) info->Buffer, 256);
Shouldn't it be tied to CONFIG_DIMM_SPD_SIZE? If you would like to use XMP profile, you may add a Kc […]
Maybe CONFIG_DIMM_SPD_SIZE isn't needed: regardless of if a particular DDR3 RAM stick provides the XMP profiles or not, its' SPD memory is always 256 bytes according to JEDEC specification - https://github.com/mikebdp2/ddr3spd/blob/master/JEDEC_DDR3_SPD_4_01_02_11R24... . It wouldn't hurt to read the extra 128 bytes from SPD even if you wouldn't use the XMP profile stored in it.