Attention is currently required from: Hung-Te Lin, Jarried Lin, Yidi Lin.
Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/84929?usp=email )
Change subject: soc/mediatek/mt8196: Add tracker driver ......................................................................
Patch Set 1:
(1 comment)
File src/soc/mediatek/mt8196/include/soc/tracker.h:
https://review.coreboot.org/c/coreboot/+/84929/comment/ee012fcc_f876cbb8?usp... : PS1, Line 41: #define BUS_DBG_CON_IRQ_AR_STA0 0x00000100 : #define BUS_DBG_CON_IRQ_AW_STA0 0x00000200 : #define BUS_DBG_CON_IRQ_AR_STA1 0x00100000 : #define BUS_DBG_CON_IRQ_AW_STA1 0x00200000 : #define BUS_DBG_CON_TIMEOUT (BUS_DBG_CON_IRQ_AR_STA0 | BUS_DBG_CON_IRQ_AW_STA0 | \ : BUS_DBG_CON_IRQ_AR_STA1 | BUS_DBG_CON_IRQ_AW_STA1) : : struct tracker { : uintptr_t base_addr; : u32 timeout; : u32 entry; : u32 offset[8]; : const char *str; : }; We should reuse tracker_common.h is possible.
- Increase offset array size from 2 to 8 in tracker_common.h - Add `tracker_dump_data` to tracker_common.h - Move `tracker_dump_data` implementation from common/tracker.c to common/tracker_dump.c - Include tracker_common.h from mt8196/tracker.c - Keep line 8-39 here in this file