Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40035 )
Change subject: soc/intel/xeon_sp/cpx: Add multi-core init
......................................................................
Patch Set 7: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/40035/7/src/soc/intel/xeon_sp/cpx/c...
File src/soc/intel/xeon_sp/cpx/cpu.c:
https://review.coreboot.org/c/coreboot/+/40035/7/src/soc/intel/xeon_sp/cpx/c...
PS7, Line 82: intel_microcode_load_unlocked
yeah this is a valid concern. However I believe this "phase 1" is taking place in FSP-T. […]
Well, however, we have to be careful with cache manipulations, since functions from the common cpu initialization code may not take into account the specifics of the CPX + fsp platform and use the cache incorrectly.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40035
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0af374ab3956009e9208917d911d29eb21db6069
Gerrit-Change-Number: 40035
Gerrit-PatchSet: 7
Gerrit-Owner: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-CC: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-CC: David Hendricks
david.hendricks@gmail.com
Gerrit-CC: Jonathan Zhang
jonzhang@fb.com
Gerrit-CC: Lijian Zhao
lijian.zhao@intel.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 02 Apr 2020 21:55:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Maxim Polyakov
max.senia.poliak@gmail.com
Comment-In-Reply-To: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-MessageType: comment