Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35189 )
Change subject: util/inteltool: add many missing registers for skl/kbl ......................................................................
Patch Set 17: Code-Review-1
(1 comment)
https://review.coreboot.org/c/coreboot/+/35189/17/util/inteltool/powermgt.c File util/inteltool/powermgt.c:
https://review.coreboot.org/c/coreboot/+/35189/17/util/inteltool/powermgt.c@... PS17, Line 888: for (i = 0; i < pm_cfg_registers_size; i++) { : switch (pm_cfg_registers[i].size) { : case 8: : printf("0x%04x: 0x%08x (%s)\n" : " 0x%08x\n", : pm_cfg_registers[i].addr, : pci_read_long(acpi, pm_cfg_registers[i].addr), : pm_cfg_registers[i].name, : pci_read_long(acpi, pm_cfg_registers[i].addr+4)); : break; : case 4: : printf("0x%04x: 0x%08x (%s)\n", : pm_cfg_registers[i].addr, : pci_read_long(acpi, pm_cfg_registers[i].addr), : pm_cfg_registers[i].name); : break; : case 2: : printf("0x%04x: 0x%04x (%s)\n", : pm_cfg_registers[i].addr, : pci_read_word(acpi, pm_cfg_registers[i].addr), : pm_cfg_registers[i].name); : break; : case 1: : printf("0x%04x: 0x%02x (%s)\n", : pm_cfg_registers[i].addr, : pci_read_byte(acpi, pm_cfg_registers[i].addr), : pm_cfg_registers[i].name); : break; : } : } make this conditional, so that it only gets run for acpi != NULL