build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39414 )
Change subject: nb/intel/pineview: Clean up code and comments ......................................................................
Patch Set 6:
(10 comments)
https://review.coreboot.org/c/coreboot/+/39414/6/src/northbridge/intel/pinev... File src/northbridge/intel/pineview/pineview.h:
https://review.coreboot.org/c/coreboot/+/39414/6/src/northbridge/intel/pinev... PS6, Line 124: #define EPBAR8(x) *((volatile u8 *)(DEFAULT_EPBAR + x)) Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/39414/6/src/northbridge/intel/pinev... PS6, Line 132: #define DMIBAR8(x) *((volatile u8 *)(DEFAULT_DMIBAR + x)) Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/39414/6/src/northbridge/intel/pinev... File src/northbridge/intel/pineview/raminit.c:
https://review.coreboot.org/c/coreboot/+/39414/6/src/northbridge/intel/pinev... PS6, Line 1230: #define TABLE static const Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/39414/6/src/northbridge/intel/pinev... PS6, Line 1233: #define FOR_EACH_RCOMP_GROUP(idx) for (idx = 0; idx < 7; idx++) if (idx != 1) Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/39414/6/src/northbridge/intel/pinev... PS6, Line 1880: if (ONLY_DIMMA_IS_POPULATED(s->dimms, 0) || ONLY_DIMMB_IS_POPULATED(s->dimms, 0)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/39414/6/src/northbridge/intel/pinev... PS6, Line 2048: if (minlanecoarse > lanecoarse[lane]) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/39414/6/src/northbridge/intel/pinev... PS6, Line 2108: if ((tom - tolud) > 64) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/39414/6/src/northbridge/intel/pinev... PS6, Line 2261: while ((MCHBAR32(COMPCTRL1) & 0x80000000) > 0) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/39414/6/src/northbridge/intel/pinev... PS6, Line 2323: if ((MCHBAR8(HMBYPCP + 3) == 0xff) && (MCHBAR8(HMCCMC) & 0x80)) { braces {} are not necessary for any arm of this statement
https://review.coreboot.org/c/coreboot/+/39414/6/src/northbridge/intel/pinev... PS6, Line 2588: const char *boot_str[] = {"Normal", "Reset", "Resume"}; char * array declaration might be better as static const