Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31270 )
Change subject: intel/spi: Define PCI accessor aliases only once
......................................................................
Patch Set 4:
If this comes from flashrom it must have been long
ago. flashrom uses libpci. Why not just use coreboot
functions proper? (or integrate libflashrom :p)
In any case, I don't think it makes sense to mention
flashrom in the source. And ofc, it might be a good
idea to consolidate the copies so the next cleanup
doesn't have to do the same changes 6 times again.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31270
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If7190ac105b2a65a9576709955c3cc840b95dcdf
Gerrit-Change-Number: 31270
Gerrit-PatchSet: 4
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: David Guckian
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: York Yang
york.yang@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Sun, 10 Feb 2019 19:57:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment