Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45698 )
Change subject: haswell/lynxpoint: Align cosmetics with Broadwell ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/45698/2/src/southbridge/intel/lynxp... File src/southbridge/intel/lynxpoint/lpc.c:
https://review.coreboot.org/c/coreboot/+/45698/2/src/southbridge/intel/lynxp... PS2, Line 449: reg32 |= (1 << 31);
maybe this is not cosmetic
It does not change the binary.
https://review.coreboot.org/c/coreboot/+/45698/2/src/southbridge/intel/lynxp... File src/southbridge/intel/lynxpoint/me_status.c:
https://review.coreboot.org/c/coreboot/+/45698/2/src/southbridge/intel/lynxp... PS2, Line 14: ,
maybe not. […]
It does not change the binary. Plus, Broadwell has more entries in this array, so it needs a comma here.
https://review.coreboot.org/c/coreboot/+/45698/2/src/southbridge/intel/lynxp... File src/southbridge/intel/lynxpoint/pcie.c:
https://review.coreboot.org/c/coreboot/+/45698/2/src/southbridge/intel/lynxp... PS2, Line 653: (0xffff << 16), (0x1414 << 16)
maybe this is not cosmetic
It does not change the binary.