Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38700 )
Change subject: drivers/intel/fsp2_0: Add callback after non-XIP FSP-M load
......................................................................
Patch Set 5:
(3 comments)
https://review.coreboot.org/c/coreboot/+/38700/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/38700/4//COMMIT_MSG@11
PS4, Line 11: increases performance but requires the memory to be reserved later.
I believe the intended design of non-XIP memory init may use a feature where executable code can be […]
Done
https://review.coreboot.org/c/coreboot/+/38700/4//COMMIT_MSG@14
PS4, Line 14: memory consumed by FSP-M.
Looks here for a better explanation: https://review.coreboot. […]
Done
https://review.coreboot.org/c/coreboot/+/38700/4/src/drivers/intel/fsp2_0/in...
File src/drivers/intel/fsp2_0/include/fsp/api.h:
https://review.coreboot.org/c/coreboot/+/38700/4/src/drivers/intel/fsp2_0/in...
PS4, Line 56: fsp_reserve_fspm_mem
I'm fine with changing the name, of course. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38700
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I04b2fff4074b720d1910ff21e1a1f841cfea8efb
Gerrit-Change-Number: 38700
Gerrit-PatchSet: 5
Gerrit-Owner: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 09 Apr 2020 12:05:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-MessageType: comment