Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40823 )
Change subject: soc/amd/picasso: Introduce enums for SPI read mode and speed
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40823/2/src/soc/amd/picasso/include...
File src/soc/amd/picasso/include/soc/southbridge.h:
https://review.coreboot.org/c/coreboot/+/40823/2/src/soc/amd/picasso/include...
PS2, Line 287: shift
'shift' should be in parens for complete correctness.
Makes sense. I will do that.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40823
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7f9778b41bd059a50f20993415ebd8702a1ad58e
Gerrit-Change-Number: 40823
Gerrit-PatchSet: 2
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 29 Apr 2020 05:48:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment