Meera Ravindranath has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38754 )
Change subject: src/soc/tigerlake: Accomodate JSP specific changes in iomap.h ......................................................................
Patch Set 4:
(6 comments)
https://review.coreboot.org/c/coreboot/+/38754/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38754/3//COMMIT_MSG@7 PS3, Line 7: IOmap
iomap […]
Done
https://review.coreboot.org/c/coreboot/+/38754/3/src/soc/intel/tigerlake/inc... File src/soc/intel/tigerlake/include/soc/iomap.h:
https://review.coreboot.org/c/coreboot/+/38754/3/src/soc/intel/tigerlake/inc... PS3, Line 86:
Prefer tab over white space
Done
https://review.coreboot.org/c/coreboot/+/38754/3/src/soc/intel/tigerlake/inc... PS3, Line 87: #define MCH_BASE_SIZE 0x8000
same
Done
https://review.coreboot.org/c/coreboot/+/38754/3/src/soc/intel/tigerlake/inc... PS3, Line 89: #define EARLY_GSPI_BASE_ADDRESS 0xfe011000
same
Done
https://review.coreboot.org/c/coreboot/+/38754/3/src/soc/intel/tigerlake/inc... PS3, Line 91: #define EARLY_I2C_BASE_ADDRESS 0xfe040000
same
Done
https://review.coreboot.org/c/coreboot/+/38754/3/src/soc/intel/tigerlake/inc... PS3, Line 92: #define EARLY_I2C_BASE(x) (EARLY_I2C_BASE_ADDRESS + (0x1000 * (x)))
same
Done