build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39285 )
Change subject: mb/intel/dedede: Add Audio support ......................................................................
Patch Set 1:
(12 comments)
https://review.coreboot.org/c/coreboot/+/39285/1/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/39285/1/src/mainboard/google/dedede... PS1, Line 19: PAD_CFG_NF(GPP_R1, NONE, DEEP, NF2), code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39285/1/src/mainboard/google/dedede... PS1, Line 19: PAD_CFG_NF(GPP_R1, NONE, DEEP, NF2), please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39285/1/src/mainboard/google/dedede... PS1, Line 21: PAD_CFG_NF(GPP_R2, NONE, DEEP, NF2), code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39285/1/src/mainboard/google/dedede... PS1, Line 21: PAD_CFG_NF(GPP_R2, NONE, DEEP, NF2), please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39285/1/src/mainboard/google/dedede... PS1, Line 23: PAD_CFG_NF(GPP_R3, NONE, DEEP, NF2), code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39285/1/src/mainboard/google/dedede... PS1, Line 23: PAD_CFG_NF(GPP_R3, NONE, DEEP, NF2), please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39285/1/src/mainboard/google/dedede... PS1, Line 25: PAD_CFG_NF(GPP_R6, NONE, DEEP, NF1), code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39285/1/src/mainboard/google/dedede... PS1, Line 25: PAD_CFG_NF(GPP_R6, NONE, DEEP, NF1), please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39285/1/src/mainboard/google/dedede... PS1, Line 27: PAD_CFG_NF(GPP_R7, NONE, DEEP, NF1), code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39285/1/src/mainboard/google/dedede... PS1, Line 27: PAD_CFG_NF(GPP_R7, NONE, DEEP, NF1), please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39285/1/src/mainboard/google/dedede... PS1, Line 150: PAD_CFG_NF(GPP_H15, NONE, DEEP, NF1), code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39285/1/src/mainboard/google/dedede... PS1, Line 150: PAD_CFG_NF(GPP_H15, NONE, DEEP, NF1), please, no spaces at the start of a line