Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35623 )
Change subject: drivers/analogix: Add anx7625 MIPI DSI/DPI to DP bridge driver
......................................................................
Patch Set 12:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35623/10/src/drivers/analogix/anx76...
File src/drivers/analogix/anx7625/anx7625.c:
https://review.coreboot.org/c/coreboot/+/35623/10/src/drivers/analogix/anx76...
PS10, Line 224: ANXERROR("pixelclock too high, act(%d), maximum(%lu)\n",
@jitao please let us know what may happen in this case.
@yuping I think we can jut add "output may be unstable."
https://review.coreboot.org/c/coreboot/+/35623/10/src/drivers/analogix/anx76...
PS10, Line 231: maximum
same - add "output may be unstable".
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35623
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I02ef29798b0257632e0750f09a4390b3d0226367
Gerrit-Change-Number: 35623
Gerrit-PatchSet: 12
Gerrit-Owner: jitao shi
jitao.shi@mediatek.com
Gerrit-Reviewer: Ben Ho
Ben.Ho@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: jitao shi
jitao.shi@mediatek.com
Gerrit-CC: Jitao Shi
jitao.shi@mediatek.corp-partner.google.com
Gerrit-CC: SJ Huang
sj.huang@mediatek.corp-partner.google.com
Gerrit-CC: Ting Shen
phoenixshen@google.com
Gerrit-Comment-Date: Mon, 16 Dec 2019 08:43:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Gerrit-MessageType: comment
