Attention is currently required from: Damien Zammit, Paul Menzel. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63318 )
Change subject: doc/mb/hp/z220_sff: Add flash override jumper info ......................................................................
Patch Set 1: Code-Review+1
(3 comments)
File Documentation/mainboard/hp/z220_sff.md:
https://review.coreboot.org/c/coreboot/+/63318/comment/7d89ee74_21129066 PS1, Line 43: However, there is a jumper on the board marked `FDO` (flash descriptor override).
Nit: Please do not wrap lines after sentences.
I think the line breaking is reasonable. If the first line being shorter than the others is too visually unappealing, I'd simply replace `descriptor` with `descriptor region`.
https://review.coreboot.org/c/coreboot/+/63318/comment/6dc7b6fb_16ad2ac2 PS1, Line 43: there is a jumper on the board
Maybe give a rough location (bottom-right or next to CPU socket).
IIRC, on the SFF board it's somewhere between the PCH and the rear I/O ports. No idea where it is on the CMT board.
https://review.coreboot.org/c/coreboot/+/63318/comment/7c26c8e6_663528ee PS1, Line 44: Setting the jumper gives you unrestricted r/w access to the whole flash internally. I remember seeing that vendor firmware on this board uses protected ranges to write-protect parts of the BIOS region, except when the FDO jumper is set. I'd mention this.