Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34260 )
Change subject: soc/intel/fsp_broadwell_de: Correct 'gpio_t' typedef
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34260/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/34260/1//COMMIT_MSG@9
PS1, Line 9: <soc/gpio.h> must typedef a gpio_t that fits in 32 bits.
because of line #23 src/include/gpio.h: […]
Sorry, I was wrongly assuming that this isn't to be taken
literraly. But if taken literraly, then I have to say: 8
bits fit into 32. So why change anything?
If it wasn't ok, the assertion would use `==` instead of `<=`?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34260
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I62b39a53ad14cefe6e98c772e8a3c4d80dd5d84e
Gerrit-Change-Number: 34260
Gerrit-PatchSet: 1
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 12 Jul 2019 17:50:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: HAOUAS Elyes
ehaouas@noos.fr
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment