Attention is currently required from: Vinod Polimera, Shelley Chen, Julius Werner. Hello Hung-Te Lin, Vinod Polimera, Shelley Chen, build bot (Jenkins), Yu-Ping Wu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56966
to look at the new patch set (#8).
Change subject: qualcomm/sc7180: Switch to common MIPI panel library ......................................................................
qualcomm/sc7180: Switch to common MIPI panel library
This patch changes the sc7180 boards to use the new common MIPI panel framework, which allows more flexible initialization command packing and sharing panel definitions between boards. (I'm taking the lane count control back out again for now, since it seems we only ever want 4 for now anyway, and if we ever have a need for a different lane count it's not clear whether that should be a property of the board or the panel or both. Better to leave that decision until we have a real use case.)
Also, the code was not written to deal with DCS commands that were not a length divisible by 4 (it would read over the end of the command buffer). The corresponding kernel driver seems to pad the command with 0xff instead, let's do the same here. (Also increase the maximum allowed command length to 256 bytes, as per Qualcomm's recommendation.)
Signed-off-by: Julius Werner jwerner@chromium.org Change-Id: I78f6efbaa9da88a3574d5c6a51061e308412340e --- M src/device/mipi/Kconfig M src/device/mipi/Makefile.inc A src/device/mipi/panel-VIS_RM69299.c M src/mainboard/google/trogdor/Kconfig M src/mainboard/google/trogdor/Makefile.inc M src/mainboard/google/trogdor/mainboard.c D src/mainboard/google/trogdor/panel_driver.c M src/soc/qualcomm/sc7180/display/dsi.c M src/soc/qualcomm/sc7180/include/soc/display/mipi_dsi.h D src/soc/qualcomm/sc7180/include/soc/display/panel.h 10 files changed, 142 insertions(+), 153 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/56966/8