Attention is currently required from: Mac Chiang, Subrata Banik.
Kapil Porwal has posted comments on this change by Mac Chiang. ( https://review.coreboot.org/c/coreboot/+/86699?usp=email )
Change subject: mb/google/fatcat/var/francka: Add support for DMIC0
......................................................................
Patch Set 6:
(1 comment)
File src/mainboard/google/fatcat/variants/francka/fw_config.c:
https://review.coreboot.org/c/coreboot/+/86699/comment/ba7175e1_53b08fae?usp... :
PS6, Line 28: /* GPP_D09: PCH_DGPU_HOLD_RST#_R */
: PAD_NC(GPP_D09, NONE),
: /* GPP_D16: HDA_RST# */
: PAD_NC(GPP_D16, NONE),
: /* GPP_S00: SNDW_3_SCL */
: PAD_NC(GPP_S00, NONE),
: /* GPP_S01: SNDW_3_SDA */
: PAD_NC(GPP_S01, NONE),
: /* GPP_S04: SNDW2_CLK */
: PAD_NC(GPP_S04, NONE),
: /* GPP_S05: SNDW2_DATA0 */
: PAD_NC(GPP_S05, NONE),
These pins are NC in either case. why not move them to gpio.c?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86699?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idcc18a6a605694bc5c1a2994453717887814e897
Gerrit-Change-Number: 86699
Gerrit-PatchSet: 6
Gerrit-Owner: Mac Chiang
mac.chiang@intel.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Pranava Y N
pranavayn@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Ian Feng
ian_feng@compal.corp-partner.google.com
Gerrit-Attention: Mac Chiang
mac.chiang@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Comment-Date: Thu, 27 Mar 2025 18:43:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No