Attention is currently required from: Máté Kukri, Nicholas Chin.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81022?usp=email )
Change subject: mb/asrock: Add Z87E-ITX (Haswell) ......................................................................
Patch Set 2: Code-Review+1
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81022/comment/044f6304_762ab920 : PS2, Line 14: socketted nit: socketed (one t)
File src/mainboard/asrock/z87e-itx/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/81022/comment/c2ddc980_62d3934d : PS2, Line 4: register "ec_present" = "false" Any zero/false options can be omitted
https://review.coreboot.org/c/coreboot/+/81022/comment/ffa07541_1f8d86d4 : PS2, Line 10: register "panel_cfg" = "{ : .up_delay_ms = 0, : .down_delay_ms = 0, : .cycle_delay_ms = 500, : .backlight_on_delay_ms = 0, : .backlight_off_delay_ms = 0, : .backlight_pwm_hz = 0, : }" There's no panel on this board
File src/mainboard/asrock/z87e-itx/gma-mainboard.ads:
https://review.coreboot.org/c/coreboot/+/81022/comment/b824f1a8_ed5a196f : PS2, Line 20: LVDS, : eDP Replace these two with `others => Disabled`
File src/mainboard/asrock/z87e-itx/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/81022/comment/3f9996ad_c22be0f6 : PS2, Line 20:
This board seems to have HDMI. […]
I thought Haswell already incorporates HDA verbs for the Mini-HD in chipset code
File src/mainboard/asrock/z87e-itx/romstage.c:
https://review.coreboot.org/c/coreboot/+/81022/comment/6075a723_04f1e95c : PS2, Line 19: /* FIXME: check this */
Can you check which ones are needed with `i2cdetect`?
It's most likely 0x50 and 0x52, the first slot of each channel.