Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38840 )
Change subject: mainboard: Add OCP Tioga Pass board ......................................................................
Patch Set 13:
(4 comments)
https://review.coreboot.org/c/coreboot/+/38840/13/src/mainboard/ocp/tiogapas... File src/mainboard/ocp/tiogapass/Kconfig:
https://review.coreboot.org/c/coreboot/+/38840/13/src/mainboard/ocp/tiogapas... PS13, Line 21: select CPU_INTEL_MODEL_XEONSP : select CPU_INTEL_MODEL_XEONSP_SKX Would selecting only one of these suffice?
https://review.coreboot.org/c/coreboot/+/38840/13/src/mainboard/ocp/tiogapas... File src/mainboard/ocp/tiogapass/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/38840/13/src/mainboard/ocp/tiogapas... PS13, Line 1: BOARD_OCP_TIOGAPASS Would `BOARD_OCP_TIOGA_PASS` look better?
https://review.coreboot.org/c/coreboot/+/38840/13/src/mainboard/ocp/tiogapas... File src/mainboard/ocp/tiogapass/board_info.txt:
https://review.coreboot.org/c/coreboot/+/38840/13/src/mainboard/ocp/tiogapas... PS13, Line 3: eval server ?
https://review.coreboot.org/c/coreboot/+/38840/13/src/mainboard/ocp/tiogapas... File src/mainboard/ocp/tiogapass/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/38840/13/src/mainboard/ocp/tiogapas... PS13, Line 7: Intel Corporation I would think this part is redundant