Attention is currently required from: Hung-Te Lin, Yu-Ping Wu.
jason-ch chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74063 )
Change subject: soc/mediatek/mt8188: Add GPIO driving functions ......................................................................
Patch Set 6:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74063/comment/a4e17007_558077f0 PS5, Line 10: This implementation is according to chapter 5.2 in MT8188 Functional
Add a blank line between paragraphs.
Done
File src/soc/mediatek/mt8188/gpio.c:
https://review.coreboot.org/c/coreboot/+/74063/comment/19169efe_3bb766e8 PS5, Line 20: spi_gpio_driving_info
(Optional) Consider `bootblock_gpio_driving_info`.
Done
https://review.coreboot.org/c/coreboot/+/74063/comment/09060bc7_43d01ee7 PS5, Line 211: GPIO_NUM
With CB:74068 now returning NULL and returning zero from `gpio_driving_adv_info` are equivalent. […]
Done