Attention is currently required from: Tarun Tuli, Eran Mitrani, Kapil Porwal, Nick Vaccaro.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70262 )
Change subject: drivers/wifi/generic: Fix properties in generic-under-PCI device case
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
Patchset:
PS2:
You need to rewrite the commit msg and give example of a case where generic device is under pci and how it eventually results into a wrong/junk information in SSDT.
A snippet of SSDT w/ and w/o your CL is way to tell what u have actually fixed.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/70262
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6f7d0b826ce067b40fa89d74f421d7018ecc3fbb
Gerrit-Change-Number: 70262
Gerrit-PatchSet: 2
Gerrit-Owner: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Comment-Date: Fri, 02 Dec 2022 10:49:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment