build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32855 )
Change subject: util: Fix typo on plural form of index ......................................................................
Patch Set 1:
(9 comments)
https://review.coreboot.org/#/c/32855/1/util/romcc/romcc.c File util/romcc/romcc.c:
https://review.coreboot.org/#/c/32855/1/util/romcc/romcc.c@14217 PS1, Line 14217: if (index >= MAX_INDICES) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/32855/1/util/romcc/romcc.c@14220 PS1, Line 14220: if (used_indices & (1 << index)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/32855/1/util/romcc/romcc.c@14242 PS1, Line 14242: for(index = 0; index < MAX_INDICES; index++) { space required before the open parenthesis '('
https://review.coreboot.org/#/c/32855/1/util/romcc/romcc.c@14243 PS1, Line 14243: if (!(used_indices & ((uint64_t)1 << index))) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/32855/1/util/romcc/romcc.c@14247 PS1, Line 14247: if (index == MAX_INDICES) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/32855/1/util/romcc/tests/raminit_test6.c File util/romcc/tests/raminit_test6.c:
https://review.coreboot.org/#/c/32855/1/util/romcc/tests/raminit_test6.c@165... PS1, Line 1654: value = spd_read_byte(ctrl->channel0[i], latency_indices[index]); line over 80 characters
https://review.coreboot.org/#/c/32855/1/util/romcc/tests/raminit_test6.c@170... PS1, Line 1704: value = spd_read_byte(ctrl->channel0[i], latency_indices[index]); line over 80 characters
https://review.coreboot.org/#/c/32855/1/util/romcc/tests/raminit_test7.c File util/romcc/tests/raminit_test7.c:
https://review.coreboot.org/#/c/32855/1/util/romcc/tests/raminit_test7.c@165... PS1, Line 1659: value = spd_read_byte(ctrl->channel0[i], latency_indices[index]); line over 80 characters
https://review.coreboot.org/#/c/32855/1/util/romcc/tests/raminit_test7.c@170... PS1, Line 1709: value = spd_read_byte(ctrl->channel0[i], latency_indices[index]); line over 80 characters