Tomasz Figa has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42205 )
Change subject: mb/google/dedede: Add ACPI support for camera in WDee
......................................................................
Patch Set 19:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42205/19/src/mainboard/google/deded...
File src/mainboard/google/dedede/variants/waddledee/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/42205/19/src/mainboard/google/deded...
PS19, Line 197: register "pr0" = ""\_SB.PCI0.I2C3.CAM1.PRIC""
Attaching the SSDT CAM related entries from WDoo, I donot have the WDee board right now […]
Thanks. So it looks like both the VCM and EEPROM are tied to the sensor power sequence, but that shouldn't be the case. It should be possible to turn them on and off separately without fully powering on the others.
Also, what are the _DSM and SSDB methods for?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42205
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3f6b490832d2c34c86512384eb7470f13a212a66
Gerrit-Change-Number: 42205
Gerrit-PatchSet: 19
Gerrit-Owner: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Andy Yeh
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kaiyen Chang
kaiyen.chang@intel.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: ShawnX Tu
shawnx.tu@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Evan Green
evgreen@chromium.org
Gerrit-CC: Matt Delco
delco@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-CC: Tomasz Figa
tfiga@google.com
Gerrit-Comment-Date: Tue, 15 Sep 2020 22:23:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Varshit B Pandya
varshit.b.pandya@intel.com
Comment-In-Reply-To: Tomasz Figa
tfiga@google.com
Gerrit-MessageType: comment