Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39893 )
Change subject: Documentation: Add proposal for firmware unit testing ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39893/1/Documentation/technotes/202... File Documentation/technotes/2020-03-unit-testing-coreboot.md:
https://review.coreboot.org/c/coreboot/+/39893/1/Documentation/technotes/202... PS1, Line 100: GPL
compatible to GPL? BSD-l wouldn't raise questions, while Apache-l might do (even though we don't dis […]
Considering that cmocka (Apache) seems to be the candidate, how do we feel about the compatibility issue? I read your "it's fine because we don't distribute binaries" argument and I guess it sounds reasonable in theory, but I am not a lawyer... are there any other known examples of someone using cmocka (or generally any Apache test framework) with GPL code? Have we asked a lawyer about this?
https://review.coreboot.org/c/coreboot/+/39893/1/Documentation/technotes/202... PS1, Line 231: every test file name : should have added a prefix "-test" Why? Seems like unnecessary boilerplate if the directory structure already makes clear which files are the tests?