Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46272 )
Change subject: soc/intel/skl + cpu/intel/common: move AES-NI locking to common cpu code ......................................................................
Patch Set 4: Code-Review+1
(3 comments)
https://review.coreboot.org/c/coreboot/+/46272/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46272/4//COMMIT_MSG@7 PS4, Line 7: soc/intel/skl + cpu/intel/common: move AES-NI locking to common cpu code In case you think too, that this is much too long, how about:
soc/intel/skl,cpu/intel: Move AES-NI locking into common code
https://review.coreboot.org/c/coreboot/+/46272/4/src/include/cpu/intel/msr.h File src/include/cpu/intel/msr.h:
https://review.coreboot.org/c/coreboot/+/46272/4/src/include/cpu/intel/msr.h... PS4, Line 8: #define MSR_FEATURE_CONFIG 0x13c Should this be removed from the other header? Users could include this fil (I guess it's only one left)?
https://review.coreboot.org/c/coreboot/+/46272/4/src/include/cpu/intel/msr.h... PS4, Line 9: #define AESNI_LOCK_BIT 0 As we mostly use bit masks in coreboot, this seems highly error-prone. I've looked ahead to see how you use it, which is ok in the context of msr_set_bit(). But it's so way off what coreboot usually looks like. Should we maybe get rid of msr_set_bit()? It doesn't seem to be used much?