Patch set 4:Code-Review +1
3 comments:
Patch Set #4, Line 7: soc/intel/skl + cpu/intel/common: move AES-NI locking to common cpu code
In case you think too, that this is much too long, how about:
soc/intel/skl,cpu/intel: Move AES-NI locking into common code
File src/include/cpu/intel/msr.h:
Patch Set #4, Line 8: #define MSR_FEATURE_CONFIG 0x13c
Should this be removed from the other header? Users could include this
fil (I guess it's only one left)?
Patch Set #4, Line 9: #define AESNI_LOCK_BIT 0
As we mostly use bit masks in coreboot, this seems highly error-prone.
I've looked ahead to see how you use it, which is ok in the context of
msr_set_bit(). But it's so way off what coreboot usually looks like.
Should we maybe get rid of msr_set_bit()? It doesn't seem to be used much?
To view, visit change 46272. To unsubscribe, or for help writing mail filters, visit settings.