Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31363 )
Change subject: mb/gigabyte: add GA-P67A-UD3R ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/#/c/31363/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31363/1//COMMIT_MSG@40 PS1, Line 40: - SATA 2 Are these untested because they broke due to the hardware bug?
https://review.coreboot.org/#/c/31363/1/src/mainboard/gigabyte/ga-p67a-ud3r/... File src/mainboard/gigabyte/ga-p67a-ud3r/dsdt.asl:
https://review.coreboot.org/#/c/31363/1/src/mainboard/gigabyte/ga-p67a-ud3r/... PS1, Line 16: #include <arch/acpi.h> Please add a blank line after this line
https://review.coreboot.org/#/c/31363/1/src/mainboard/gigabyte/ga-p67a-ud3r/... PS1, Line 26: // Some generic macros Please remove
https://review.coreboot.org/#/c/31363/1/src/mainboard/gigabyte/ga-p67a-ud3r/... File src/mainboard/gigabyte/ga-p67a-ud3r/romstage.c:
https://review.coreboot.org/#/c/31363/1/src/mainboard/gigabyte/ga-p67a-ud3r/... PS1, Line 65: /* Disable SIO WDT which kicks in DualBIOS */ This line looks familiar.