Attention is currently required from: Sean Rhodes, Angel Pons, Lean Sheng Tan.
Hello build bot (Jenkins), Sean Rhodes, Angel Pons, Lean Sheng Tan,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/73903
to review the following change.
Change subject: Revert "device: Add Kconfig options for D3COLD_SUPPORT and NO_S0IX_SUPPORT" ......................................................................
Revert "device: Add Kconfig options for D3COLD_SUPPORT and NO_S0IX_SUPPORT"
This reverts commit 655f7362e13ca49e3e13a822c916c7dc52573d74.
Reason for revert: Apperently, the change was not properly reviewed. It not only contains conflicting name and description of the D3COLD Kconfig, but also creates a conflict between existing devicetree and Kconfig options for D3Cold/S3/S0ix.
Change-Id: I56ce8f59f8548fc58bc2b3b07c1314e2eed7061c --- M src/device/Kconfig 1 file changed, 16 insertions(+), 13 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/73903/1
diff --git a/src/device/Kconfig b/src/device/Kconfig index d79634f..fdedf46 100644 --- a/src/device/Kconfig +++ b/src/device/Kconfig @@ -994,19 +994,6 @@ help Provides xHCI utility functions.
-config NO_S0IX_SUPPORT - bool "Don't support S0IX suspend" - default n - help - Select if the board only supports S3 and/or S4 and not S0IX - -config D3COLD_SUPPORT - bool "Don't support D3Cold" - default n if NO_S0IX_SUPPORT - default y - help - Select if any devices don't support D3Cold state - source "src/device/dram/Kconfig"
endmenu