Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39639 )
Change subject: Revert "src/mb/google/volteer: Add camera ACPI configuration" ......................................................................
Patch Set 2:
Patch Set 2:
#1, We did not expect the patch for volteer was merged soon and it was prepared for cherry pick for proto2 PO as Nick's cheery pick patch will not work as it is. Daniel created patch based on last review feedback(clean up and update acpi based on Camera spec) which is same as TGL RVP patch.
If you did not expect the patch to be merged, please do not mark +2 Code Review.
==> Sure, we'll do.
#2, We planed to add more reviewer soon but it's merged before adding. The patch for TGL RVP included Google engineers.
You should be adding volteer team members right away when you are reviewing the CL. Else, there are going to be misses and surprises.
==> We'll do
#3, We're preparing ETA with JSL team as SSDT for Camera is common module change. We'll update soon.
Do you have an ETA?
==> Rizwan will provide design document and will also provide ETA based on design document review.
I think we can remove this DSDT acpi change when we push SSDT change.
I don't think the DSDT is doing everything correctly. I have posted some comments on the original CL.
==> We'll review the comments as SSDT consider review comments.