Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47803 )
Change subject: vendorcode/intel/fsp: Add Elkhart Lake FSP headers for FSP v2341
......................................................................
Patch Set 1: Code-Review+2
(2 comments)
Will this ever be moved to 3rdparty/fsp?
https://review.coreboot.org/c/coreboot/+/47803/1/src/vendorcode/intel/fsp/fs...
File src/vendorcode/intel/fsp/fsp2_0/elkhartlake/FirmwareVersionInfoHob.h:
https://review.coreboot.org/c/coreboot/+/47803/1/src/vendorcode/intel/fsp/fs...
PS1, Line 39: ///< Offset 0 Index of Component Name
Yes Werner, this is the standard version across all platforms. […]
Yes, I got the context.
https://review.coreboot.org/c/coreboot/+/47803/1/src/vendorcode/intel/fsp/fs...
File src/vendorcode/intel/fsp/fsp2_0/elkhartlake/FspmUpd.h:
https://review.coreboot.org/c/coreboot/+/47803/1/src/vendorcode/intel/fsp/fs...
PS1, Line 3027:
Yes you are right haha.. […]
Sure, just a nit.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47803
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I98f738402490b47efa1a346f81db47857e384e13
Gerrit-Change-Number: 47803
Gerrit-PatchSet: 1
Gerrit-Owner: Lean Sheng Tan
lean.sheng.tan@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 24 Nov 2020 09:59:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Lean Sheng Tan
lean.sheng.tan@intel.com
Comment-In-Reply-To: Werner Zeh
werner.zeh@siemens.com
Gerrit-MessageType: comment