Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38700 )
Change subject: drivers/intel/fsp2_0: Add weak reservation for FSP-M memory
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38700/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/38700/4//COMMIT_MSG@11
PS4, Line 11: increases performance but requires the memory to be reserved later.
Why later? what happens further with the memory?
https://review.coreboot.org/c/coreboot/+/38700/4//COMMIT_MSG@14
PS4, Line 14: memory consumed by FSP-M.
What will it do with the information? What makes it platform specific?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38700
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I04b2fff4074b720d1910ff21e1a1f841cfea8efb
Gerrit-Change-Number: 38700
Gerrit-PatchSet: 4
Gerrit-Owner: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 07 Apr 2020 21:20:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment