Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39615 )
Change subject: sc7180: Add display hardware pipe line initialization
......................................................................
Patch Set 37:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39615/35/src/mainboard/google/trogd...
File src/mainboard/google/trogdor/board.h:
https://review.coreboot.org/c/coreboot/+/39615/35/src/mainboard/google/trogd...
PS35, Line 13: #define GPIO_WP_STATE GPIO(42)
Sorry, my bad. I will remove these lines.
Yes, they're unused, please just remove them.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39615
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7d5e3f1781c48759553243abeb3d694f76cd008e
Gerrit-Change-Number: 39615
Gerrit-PatchSet: 37
Gerrit-Owner: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Ravi Kumar Bokka
c_rbokka@qualcomm.corp-partner.google.com
Gerrit-CC: Vinod Polimera
vpolimer@qualcomm.corp-partner.google.com
Gerrit-Comment-Date: Thu, 03 Sep 2020 22:49:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Vinod Polimera
vpolimer@qualcomm.corp-partner.google.com
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment