Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39121 )
Change subject: mb/google/dedede: configure ESPI IO decode range for chrome EC ......................................................................
Patch Set 2:
(1 comment)
Patch Set 2:
LGTM, but just a thought, do we want to move the LPC generic IO decode ranges to our EC driver? Then we don't have to keep adding it to every mainboard's devicetree.
This I/O decode range configuration seems to be Intel SoC specific - not the range itself, but the register value. So moving to the EC driver may be tricky and might require SoC knowledge in there.
https://review.coreboot.org/c/coreboot/+/39121/2/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/39121/2/src/mainboard/google/dedede... PS2, Line 23: f
It's a mask on the address applied (and is 0x3F in this case), meaning decode all 6 available addres […]
Discussed offline with Tim and we found that 0xfc translates to 0x3f number of words as accessible in that region.