Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31606 )
Change subject: libpayload: cbfs: Require input size and output size for cbfs_decompress
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/31606/1/payloads/libpayload/include/cbfs_cor...
File payloads/libpayload/include/cbfs_core.h:
https://review.coreboot.org/#/c/31606/1/payloads/libpayload/include/cbfs_cor...
PS1, Line 257: int srcn
These should be changed to size_t while we're here.
edit: return value too, please. all the functions called from here return unsigned.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31606
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibe617825bd000ed618791d8e3c5f65bbbd5f7e33
Gerrit-Change-Number: 31606
Gerrit-PatchSet: 1
Gerrit-Owner: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: Daisuke Nojiri
dnojiri@chromium.org
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 26 Feb 2019 03:41:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment