Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36043 )
Change subject: soc/intel/cannonlake: Add gfx.asl file
......................................................................
Patch Set 11:
Patch Set 10:
Patch Set 10:
Patch Set 10:
does this need to be #included somewhere?
I see it included in the last commit now. You could just #include it in northbridge.asl instead of needing to add it to the mainboard ASL.
northbridge or southbridge, should it always be included or based on some config flag?
Probably in northbridge, and it could be included always as it will get ignored if the PCI device doesn't exist.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36043
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I38a26f3135d571e2f9b63840d38fd4d3476fc142
Gerrit-Change-Number: 36043
Gerrit-PatchSet: 11
Gerrit-Owner: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Duncan Laurie
dlaurie@chromium.org
Gerrit-Comment-Date: Thu, 07 Nov 2019 21:31:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment