Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46436 )
Change subject: volteer+vendorcode: Cr50 version code only via SPI ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46436/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46436/3//COMMIT_MSG@7 PS3, Line 7: r50 version code only via SPI add a verb?
https://review.coreboot.org/c/coreboot/+/46436/3/src/mainboard/google/voltee... File src/mainboard/google/volteer/mainboard.c:
https://review.coreboot.org/c/coreboot/+/46436/3/src/mainboard/google/voltee... PS3, Line 55: && the operator usually goes on the preceding line