Attention is currently required from: Xi Chen, Chien-Chih Tseng, Pi-Cheng Chen, Rex-BC Chen, Yu-Ping Wu.
flora.fu@mediatek.com has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48622 )
Change subject: soc/mediatek/mt8192: add apusys init flow
......................................................................
Patch Set 14:
(2 comments)
File src/soc/mediatek/mt8192/include/soc/apusys.h:
https://review.coreboot.org/c/coreboot/+/48622/comment/a07cdc22_4913e438
PS13, Line 19: 4
Don't need this.
Done
https://review.coreboot.org/c/coreboot/+/48622/comment/bc55b848_658ef379
PS13, Line 23: )
Add a trailing comma
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48622
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If05a8af1a2f96598adcf70e15003e4f5dc94e337
Gerrit-Change-Number: 48622
Gerrit-PatchSet: 14
Gerrit-Owner: Chien-Chih Tseng
chien-chih.tseng@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Pi-Cheng Chen
pi-cheng.chen@mediatek.com
Gerrit-Reviewer: Rex-BC Chen
rex-bc.chen@mediatek.corp-partner.google.com
Gerrit-Reviewer: Xi Chen
xixi.chen@mediatek.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: flora.fu@mediatek.com
flora.fu@mediatek.com
Gerrit-Attention: Xi Chen
xixi.chen@mediatek.com
Gerrit-Attention: Chien-Chih Tseng
chien-chih.tseng@mediatek.com
Gerrit-Attention: Pi-Cheng Chen
pi-cheng.chen@mediatek.com
Gerrit-Attention: Rex-BC Chen
rex-bc.chen@mediatek.corp-partner.google.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Fri, 07 May 2021 08:36:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment